potentially incorrect conversion of pointer to unsigned long

Oswald Buddenhagen oswald.buddenhagen at gmx.de
Sat Jun 22 10:40:39 UTC 2019


On Sat, Jun 22, 2019 at 09:42:36AM +0200, Vincent Lefevre wrote:
>         p->init = (unsigned long) safe_strdup (* ((char **) p->data));
>
> IMHO, the best solution for safety would be to use a union (I think
> that this would require the use of C99 designators for the MuttVars
> initialization). Otherwise check (uintptr_t) -1 <= (unsigned long) -1
> in configure.
> 
it's easier to just use !! or put != NULL at the end instead of the cast.


More information about the Mutt-dev mailing list