[PATCH] Add ~M pattern to match mime Content-Types.

Ammon Riley ammon.riley at gmail.com
Fri Apr 27 19:57:01 UTC 2018


On Fri, Apr 27, 2018 at 12:18 PM, Kevin J. McCarthy <kevin at 8t8.us> wrote:
> On Fri, Apr 27, 2018 at 12:13:54PM -0700, Ammon Riley wrote:
>> On Fri, Apr 27, 2018 at 12:09 PM, Kevin J. McCarthy <kevin at 8t8.us> wrote:
>> > On Fri, Apr 27, 2018 at 11:05:28AM -0700, Ammon Riley wrote:
>> >> However, looking at imap_read_headers(), I see that it fetches the
>> >> Content-Type header.  There's a comment near the bottom that
>> >> reads "content built as a side-effect of mutt_read_rfc822_header",
>> >> which does indeed parse Content-Type headers, and builds the
>> >> part structure.  It's not clear to me if the IMAP server returns *all*
>> >> of the Content-Type headers.
>> >
>> > No, mutt_read_rfc822_header() is dealing with the email header.  The
>> > IMAP server is only returning a content-type for the email header, not
>> > the various parts.
>>
>> Then in that case, I'll amend the documentation for ~M to specify that
>> the search is done locally, so that IMAP users know it could potentially
>> be expensive.
>
> I was thinking about it a bit, and I think it would be good to label
> the slower patterns with "***)" and add an explanation below.
>
> However, if you'd like I'll be glad to do that after pushing your commit
> up.

That sounds better.  I'll let you do that, as I don't know off the top of
my head which are slow. :)

Thanks!

A


More information about the Mutt-dev mailing list