Problem with mutt version.sh script

Vincent Lefevre vincent at vinc17.org
Tue Apr 17 13:27:51 UTC 2018


On 2018-04-16 07:53:56 -0500, Paul Keusemann wrote:
> I have just built mutt-1.9.5 on several platforms and ran into a problem
> with the version.sh script on systems where /bin/sh is not bash.

I suppose you meant... where /bin/sh is not a POSIX shell.

On 2018-04-16 09:26:51 -0700, Kevin J. McCarthy wrote:
> Originally, the test was '-d', but as Aaron notes, .git can be a file
> too.  I thought having dash as /bin/sh would catch these issues but
> somehow the '-e' problem slipped past us.

It would be a bug if -e were not supported under dash since -e is
specified by POSIX.

> Aaron, your suggestion of '-r' looks like a good idea.  Does anyone know
> of a problem with that?  Otherwise I'll swap that out in version.sh and
> mkreldate.sh.

I suppose that -r should work since .git must be readable to be
useful.

-- 
Vincent Lefèvre <vincent at vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)


More information about the Mutt-dev mailing list